[nas] [patch] RFC: remove _SvxConst ...

[Jon Trulson]

On Tue, 11 Jul 2006, Stefan Huehner wrote:

> Hi,
>
> in the nas code there are several constructs such as:
>
> #ifndef _SvxConst
> #if __STDC__ || defined(__cplusplus) || defined(c_plusplus) || (FUNCPROTO&4)
> #define _SvxConst const
> #else
> #define _SvxConst                              /**/
> #endif
> #endif                                         /* _SvxConst
>
> where support for i.e. the ansi C 'const' modifier is conditionally included.
>

> Please comment on the attached patch which removes the macro and
>replaces all its uses directly with 'const'. Imho this makes the code
>more readable. Additionally nearly all compilers should support the
>const keyword, and there are lots of places in the code which use
>uncoditional 'const'.


         Yeah, by all means, kill them.  I really have no interest in
         K&R C and 10-15 year old compilers :)  I don't think anyone
         else here does either.  If so, speak up!

         BTW: I did not see a patch...?

-- 
Jon Trulson
mailto:jon at radscan.com http://radscan.com/~jon
#include <std/disclaimer.h>
"No Kill I" -Horta