[nas] [patch] RFC: remove _SvxConst ...

Stefan Huehner stefan at huehner.org
Tue Jul 11 10:42:16 MDT 2006


Hi,

in the nas code there are several constructs such as:

#ifndef _SvxConst
#if __STDC__ || defined(__cplusplus) || defined(c_plusplus) || (FUNCPROTO&4)
#define _SvxConst const
#else
#define _SvxConst                              /**/
#endif
#endif                                         /* _SvxConst 

where support for i.e. the ansi C 'const' modifier is conditionally included. 

Please comment on the attached patch which removes the macro and replaces all its uses directly with 'const'. Imho this makes the code more readable. Additionally nearly all compilers should support the const keyword, and there are lots of places in the code which use uncoditional 'const'.

Regards,
Stefan




More information about the Nas mailing list