[nas] Re: Couple of nas things

[Jon Trulson]

On Fri, 3 Jun 2005, Mark Davies wrote:

> Hi,
>   Attached are a couple of patches for nas and some questions.
>
> Firstly some makes have a problem with the TAB before EXTRA_DEFINES =
> -DBSD44SOCKETS so replace it with a space:

 	Yes, that would be proper anyway...

> Next are some patches from Joerg Sonnenberger (a DragonFly developer) to add
> DragonFly support.  You will also need to update your
> {configure,config.guess,config.sub} in the config directory to newer versions
> that know about DragonFly.

 	Ahh.. I need to update autoconf? or?  What version contains 
knowlege of DragonFly?

[...]

>
> --- server/os/WaitFor.c.orig	2002-07-24 13:41:07.000000000 +1200
> +++ server/os/WaitFor.c	2005-06-03 01:06:28.000000000 +1200
> @@ -126,7 +126,9 @@
> extern Bool EstablishNewConnections();
> extern void ResetOsBuffers();
>
> +#ifndef errno
> extern int errno;
> +#endif
>
> #ifdef apollo
> extern long apInputMask[];
>
>
> One comment from me about the WaitFor.c patch.  Since that file already does
> an include of <errno.h>  shouldn't we just delete this "extern int errno"
> line completely?
>

 	Hmm.  Yes, I would prefer to simply delete it (it's wrong on 
modern systems anyway).  For those older systems that do not contain the 
proper errno int in errno.h (are there any we care about?), we can handle 
those special cases with ifdefs.  Soound ok?

 	Or maybe do an autoconf rule to detect this case?

> And finally in server/Imakefile there is various stuff to install the
> nasd.conf manual page to various different places and with different
> extensions for different platforms.  Wouldn't it be better to just always
> install it in the $FILEMANDIR?
> That is to say replace the:

 	Hmm..  RCMANDIR == FILEMANDIR only on linux at the moment, 
everyone else uses MANDIR...  Won't this be a problem for other OS's? 
Does everyone else define FILEMANDIR?  Personally, I don't really care as 
long as 'man nasd.conf' works :)

> and remove all the places that RCMAN{DIR,SUFFIX} are set?
>

 	If this won't break other systems, I certainly have no problem 
with that... I'll cc the NAS list in case someone has an opinion on this 
one way or the other...

 	Were you going to send seperate patch(es) I can apply? Or should I 
cut/paste from your email?  Also let me know what autoconf tool(s) I'll 
need to update for DragonFly support.  I sometimes find autoconf upgrades 
tend to break things, so I do not want to do it unneccessarily :)

> cheers
> mark
>

 	Thanks!

-- 
Jon Trulson    mailto:jon at radscan.com
ID: 1A9A2B09, FP: C23F328A721264E7 B6188192EC733962
PGP keys at http://radscan.com/~jon/PGPKeys.txt
#include <std/disclaimer.h>
"I am Nomad." -Nomad