[nas] [patch] remove exported NoopDDA function
jon at radscan.com
Wed Aug 30 18:48:05 MDT 2006
On Wed, 30 Aug 2006, Erik Auerswald wrote:
> On Wed, Aug 30, 2006 at 02:23:23PM +0200, Stefan Huehner wrote:
>> there is a empty NoopDDA function in dixutils.c which is exported and
>> listed in dix.h but only used in one place: resource.c . This patch
>> moves this functions to resource.c and modifies the parameters/return
>> value to match the expected values there.
> The DeleteFuncs seem to be of type (int *) (pointer, AuID), not
> (int *) (void).
Erik is correct...
I did not apply this patch anyways, as it really *is* useful
to have a no-op callback in dix (ahem, sorry: dia :). Athough
it is only being used internally in one place at the moment,
it will be useful to have if extensions or other server
modifications are ever made that create and manipulate new
server resources - so I think we should leave it alone...
I did, however, go though and fix the appropriate typedef, and
correct the various build issues that entailed :)
mailto:jon at radscan.com http://radscan.com/~jon
"No Kill I" -Horta
More information about the Nas