[nas] [patch] more include file cleanup
jon at radscan.com
Sat Aug 19 23:08:22 MDT 2006
On Sat, 19 Aug 2006, Stefan Huehner wrote:
> attached patch removes some more unsused part of various header files:
> - server/include/os.h
> leftovers from the x-headers
> - server/dia/globals.[ch]
> The two variables 'globalSerialNumber' and 'lastDeviceEventTime'
> are only once assigned in globals.c but are never read or
> modified afterwards.
> The patch removes the initialization and the declaration in the
> various headers.
> As globals.h is linked to the include/ directory this also
> removes these two declarations from the externally visible
> portion of the api. But as these aren't used inside nas i would
> wonder if any code linking to nas would use them. A mentioning
> in some document should imho be sufficient.
applied. No external clients should be accessing the server
includes anyway (global.h).
mailto:jon at radscan.com http://radscan.com/~jon
"No Kill I" -Horta
More information about the Nas