[nas] (resend) hard hang in libaoss.so

[Erik Auerswald]

Hi,

On Thu, Jul 04, 2013 at 08:44:49AM -0400, Paul Fox wrote:
> erik wrote:
>  > On Wed, Jul 03, 2013 at 04:09:30PM -0400, Paul Fox wrote:
>  > > i believe the problem is that if we take an alarm signal while still
>  > > in the middle of disableProcessFlow(), we'll call disableProcessFlow()
>  > > again.  so rather than clearing the processFlowEnabled flag when we're
>  > > finished disabling, we should probably clear it beforehand, as in this
>  > > patch.
>  > 
>  > The idea sounds right, and on Linux (or rather not on SCO) it should reduce
>  > the race window significantly.
> 
> do you see obvious further window(s)?

I didn't, but I'd like Jon to comment on this. He is much more familiar
with the code than I am.

>  > Does the following patch work as well?
> 
> i'm sure it would.  but i was actually going to suggest a different,
> second patch.  i was going to suggest removing the sco ifdefs entirely.
> 
> thoughts?

IMHO the sco #ifdefs should be removed. They complicate reading the code,
encumbering maintenance (as in this case).

I still think we should first address the issue at hand (reducing the race
window), perhaps even making a maintenance release with this fix.

Afterwards we should remove the sco #ifdefs in one go from the
voxware server.

If someone wants to help maintain SCO compatibility, feel free to speak up.
:-)

Comments?

Erik
-- 
But hey, don't listen to me - I like C++, and approve of Java.
                        -- Andrew Morton