[nas] [PATCH] Fix warnings about 'free' in nasd on GNU/Linux x86

[Erik Auerswald]

Hi,

On 08/16/2013 09:32 PM, Jon Trulson wrote:
> On Fri, 16 Aug 2013, Erik Auerswald wrote:
>> On 08/16/2013 05:51 PM, Marcos Mayorga wrote:
>>> something must be wrong if it doesn't compile just because
>>> #include <stdlib.h>,
>>
>> Yes, something is strange...
>>
>> This compiles (without warnings):
>>
>> ---8<---
>> Index: server/dia/auevents.c
>> ===================================================================
>> --- server/dia/auevents.c    (revision 289)
>> +++ server/dia/auevents.c    (working copy)
>> @@ -22,6 +22,7 @@
>>  * $NCDId: @(#)auevents.c,v 1.9 1994/04/21 21:50:59 greg Exp $
>>  */
>>
>> +#include        <stdlib.h>
>> #include        "misc.h"
>> #include        "dixstruct.h"
>>
>> ---8<---
>>
>> But this fails:
>>
>> ---8<---
>> Index: server/dia/auevents.c
>> ===================================================================
>> --- server/dia/auevents.c    (revision 289)
>> +++ server/dia/auevents.c    (working copy)
>> @@ -23,6 +23,7 @@
>>  */
>>
>> #include        "misc.h"
>> +#include        <stdlib.h>
>> #include        "dixstruct.h"
>>
>> #ifdef sgi
>> ---8<---
>
>
> The failure is probably due to all the macro def/redefs in misc.h (and
> the files it includes, particularly Xosdef.h)...
>
>> Any suggestions? What do you think about the attached patch?
>>
> I'm ok with the auevents.c patch, but not the connection.c patch (see
> my previous post and suggested patch for that).

That's fine. :-)

Thanks,
Erik