[nas] [PATCH] Fix build failures with binutils-gold (etc.)

[Jon Trulson]

On Tue, 3 May 2011, Erik Auerswald wrote:

> Hi Steve,
>
> On Sun, May 01, 2011 at 04:36:11AM +0200, Erik Auerswald wrote:
>> On 05/01/2011 03:06 AM, Erik Auerswald wrote:
>>> On 04/30/2011 06:24 PM, Steve McIntyre wrote:
>>>> A number of projects have changed default link behaviour in
>>>> binutils(-gold) such that --no-add-needed is now standard. This breaks
>>>> the nas build for various of the client programs. I've just added this
>>>> patch to the Debian package build which fixes the problem for me...
>>>
>>> The patch looks good. It adds -lXau to the build, but other than this I
>>> don't see a difference in build output on Debian/Unstable.
>>>
>>> Is there an easy way to enable the --no-add-needed option just for testing?
>>
>> I was not able to reproduce any build errors by specifying
>> --no-add-needed as a linker option. Thus I did not see any difference in
>> adding -lXau besides the changed compiler invocation.
>
> I think you are seeing an issue already fixed in SVN, but not in the
> release NAS version. Please take a look at
> http://radscan.com/nas/nas-ml/msg01725.html
> and the following messages in the thread.
>
> Unless you can provide evidence that there really is some problem building
> some (which?) NAS clients with the --no-add-needed linker option I will not
> add -lXau to the build.
>

   Sorry for the delay - been gone for a bit.

   I think Erik is correct - this should be working in latest svn... A
   dependancy on libXau will be created on libaudio during linking.

   Then, any apps that link with libaudio will automatically get libXau
   as well...

   From what I've read, '--no-as-needed' is purely an optimization and
   should not affect linking operations or normal shared lib dependancy
   tracking.

   If this isn't working, could you send a log of a full 'make World' ?

   Guess it's time for a maintenence 1.9.3 release too?


-- 
Jon Trulson
mailto:jon at radscan.com

If you can lead it to water and force it to drink, it isn't a horse.