[nas] [PATCH] Fix build failures with binutils-gold (etc.)

[Erik Auerswald]

Hi Steve,

On 05/01/2011 03:06 AM, Erik Auerswald wrote:
> On 04/30/2011 06:24 PM, Steve McIntyre wrote:
>> A number of projects have changed default link behaviour in
>> binutils(-gold) such that --no-add-needed is now standard. This breaks
>> the nas build for various of the client programs. I've just added this
>> patch to the Debian package build which fixes the problem for me...
>
> The patch looks good. It adds -lXau to the build, but other than this I
> don't see a difference in build output on Debian/Unstable.
>
> Is there an easy way to enable the --no-add-needed option just for testing?

I was not able to reproduce any build errors by specifying 
--no-add-needed as a linker option. Thus I did not see any difference in 
adding -lXau besides the changed compiler invocation.

$ ld --version | head -n 1
GNU ld (GNU Binutils for Debian) 2.21.51.20110421

Anyway, IMHO the attached patch uses a better place to add -lXau.
Actually, I'd tend to add -lXau to the AUDIOLIBS line unconditionally.

Regards,
Erik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nas-link-v2.patch
Type: text/x-diff
Size: 522 bytes
Desc: not available
URL: <http://radscan.com/pipermail/nas/attachments/20110501/25a34da7/attachment.patch>