[nas] patch: missing return value
Paul Fox
pgf at foxharp.boston.ma.us
Wed Jul 26 07:35:51 MDT 2006
jon wrote:
> On Tue, 25 Jul 2006, Paul Fox wrote:
> > if i put together a patch that turns the server into roughly K&R
> > style, with 4 column indents, no tabs, would that work for
> > everyone?
> >
>
> I believe I could cope. :)
>
okay then.
i just experimented with astyle, bcpp, and indent. since indent
was the only one to correctly indent, and therefore spot the bug,
at line 249 of os/WaitFor.c, i'll be using indent. (the block of
code in that hpux ifdef should have braces around it.)
indent also complains about the foo=-1 ambiguity, which i like.
so i'm going to try using:
indent -kr --no-tabs \
--indent-level4 \
--procnames-start-lines \
--declaration-indentation4 \
--continuation-indentation8
and see what happens.
i'm going to refrain from making any code changes at the same
time, so that this patch can be "purely" indentation changes.
i'll make a note any obvious bugs, or ugliness that requires
rearranging code, so that there can be a followon patch or two.
paul
=---------------------
paul fox, pgf at foxharp.boston.ma.us (arlington, ma, where it's 70.5 degrees)
More information about the Nas
mailing list