[nas] [PATCH] changed method of setting the input gain

[Erik Auerswald]

Hi,

On Sun, Jul 23, 2006 at 10:29:07PM -0600, Jon Trulson wrote:
> On Mon, 24 Jul 2006, Erik Auerswald wrote:
> >
> >the attached patch changes the way the input gain is controlled. After
> >reading some docs and googling a bit it seems that the method currently
> >used in the voxware server was correct for OSS 3.0. For some cards
> >(Soundblaster) a seperate RECLEV setting existed which could (should?)
> >be used. The RECLEV method has been superseded by using IGain since. OSS
> >4.0 uses different ioctrls, but it shall be compatible when used with
> >older drivers.
> >
> >With this patch the voxware server tries to use IGain, if that fails
> >RECLEV and if that fails LINE and MIC. This should work for old and new
> >hardware, I hope. If this logic fails on some hw/driver combination a
> >config option to manually specify which method to use can be added.
> >
> 
>         Looks good - applied.

Thanks. :-)

> >The "mixerinit" option (translated to leave_mixer in auvoxware.c) works
> >the same before and after the patch. IMHO this option needs some
> >overhaul -- it should leave the mixer settings and not set the default
> >values. An additional option "nomixer" could be added to tell nasd not
> >to open a mixer device.
> >
> 
>         Hmm... It should setup default gains and recsrc if mixerinit
>         is true.

That's my opinion as well.

>         It should probaby setup these defaults every time it
>         opens the device, shouldn't it?

I don't think so. The defaults should be applied the first time the
device is opened. After that the last set values should be activated
(what is done now to keep the changes made while the device was
released).

>         It does not appear to qork
>         quite that way currently... It seems to only prevent RECSRC
>         from being setup.

Yes, that's the reason I think the behaviour should be changed.

Erik