[nas] [PATCH] K&R -> ANSI in server/dda/voxware/
Jon Trulson
jon at radscan.com
Wed Jul 19 22:55:35 MDT 2006
On Thu, 20 Jul 2006, Erik Auerswald wrote:
> Hi,
>
> attached patch converts most K&R style code to ANSI C in the voxware
> server.
>
> There is one part of the code I'm not sure about (and therefore did not
> touch it):
>
> static void
> #ifdef sco
> intervalProc(int i)
> #else
> intervalProc()
> #endif /* sco */
>
> (starting in line 893 in the unpatched server/dda/voxware/auvoxware.c
> file)
>
> I do not know if it should be intervalProc(void) on some systems or not.
> At least on linux (and presumably SCO) it should be intervalProc(int i).
> But changing #ifdef sco -> #if defined(sco) || defined(linux) is a
> seperate issue.
Well it's a signal handler, so I think it should be int on all
systems. The arg isn't actually used (should be the signal number
that triggered it, but for correctness, it should be supplied. I've
gone ahead and made this change.
>
> Erik
>
> P.S. Thanks for applying my patches. :-)
>
Hey, thanks for suppling good ones! :)
--
Jon Trulson
mailto:jon at radscan.com http://radscan.com/~jon
#include <std/disclaimer.h>
"No Kill I" -Horta
More information about the Nas
mailing list