[nas] [PATCH] use the mixer specified in the input section

[Jon Trulson]

On Thu, 17 Aug 2006, Erik Auerswald wrote:

> Hi,
>
> On Wed, Aug 16, 2006 at 08:26:20PM +0200, Erik Auerswald wrote:
>> On Wed, Aug 16, 2006 at 01:36:42PM -0400, Paul Fox wrote:
>>> erik wrote:
>>> > Yes, the default behaviour is changed. The default config should be
>>> > adjusted as well to use /dev/mixer for in- and output. Sorry that I
>>> > forgot to do this.
>>>
>>> i'm also concerned about people with pre-installed configs that
>>> install a new nas daemon, and get surprising results.  but i
>>> guess that's progress.  :-)
>>
>> Attached is a second version of my patch that implements an _untested_
>> fallback for incorrect config files specifying a non-existant mixer
>> device in the input section. It's modelled after the equivalent
>> functionality to fall back from /dev/dsp1 to /dev/dsp.
>
> I've just tested that patch and updated it to report the correct mixer
> device name after switching to the shared device case. See the
> attachement.
>
> Erik
>

         Ok, I've committed this patch.  Nice work! :)

         I do not have an input device to test with, but it worked just
         fine on my setup - I noticed no ill behavior.

         FWIW, this is the output I get (pretty much default config on
         an SB PCI using alsa oss emulation):

         ...
         initMixer: opened output mixer device /dev/mixer
         initMixer: opened input mixer device /dev/mixer1
         initMixer: /dev/mixer1: using recording level control method 1
         Init: initMixer was successful
         ...

         Here is some suggested wording for a Note/Warning regarding
         the possible changed behavior.  To be honest, I doubt it will
         be an issue for anyone, other than the fact that input works a
         heck of a lot better than 2 months ago :)

             NOTE: Prior to this patch, the mixer device parameter for
                   the input section was completely ignored.  The
                   default value for this ignored parameter was
                   "/dev/mixer1".

                   With this patch, this parameter is honored.  If your
                   configuration depends on the input mixer being the
                   same as the output mixer, you will need to edit your
                   /etc/nas/nasd.conf and set the mixer parameter in
                   the inputsection to '/dev/mixer', or to whatever
                   mixer device your outputsection is using.

                   If your system contains a /dev/mixer1 device (the
                   default input mixer device), nasd will now use it.
                   This is a good thing. :)


-- 
Jon Trulson
mailto:jon at radscan.com http://radscan.com/~jon
#include <std/disclaimer.h>
"No Kill I" -Horta