[nas] Bug in server if client gone?

[Jon Trulson]

On Wed, 26 Sep 2001, Peter Berg Larsen wrote:

> Date: Wed, 26 Sep 2001 23:31:16 +0200 (MET DST)
> From: Peter Berg Larsen <pebl at math.ku.dk>
> To: nas at radscan.com
> Subject: [nas] Bug in server if client gone?
> 
> 
> 
[...]

> Note the osPrivate is nil, but WriteToClient tries to:
> 
> 
> #if !defined(AMOEBA) && !defined(_MINIX)
> int
> WriteToClient (who, count, buf)
>     ClientPtr who;
>     char *buf;
>     int count;
> {
>     OsCommPtr oc = (OsCommPtr)who->osPrivate;
>     register ConnectionOutputPtr oco = oc->output;
>     int padBytes;
> [...]
> 
> 
> Now is the fault that osPrivat is nil or that none of the called functions
> checks whether the clientGone is set?
> 

	As near as I can tell osPrivate should not be NULL if there are
active client connections, and WriteToClient certainly should not be
called for a dead client.


-- 
Jon Trulson    mailto:jon at radscan.com
ID: 1A9A2B09, FP: C23F328A721264E7 B6188192EC733962
PGP keys at http://radscan.com/~jon/PGPKeys.txt
#include <std/disclaimer.h>
Bad Color Temperature, Too much Peach.