[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [nas] 2 possible patches for the 1.9.1 version
On Fri, 2 Nov 2007, Frank Büttner wrote:
[...]
And https://bugzilla.redhat.com/show_bug.cgi?id=250453
Patch:
diff -Naur nas-1.9.org/lib/audio/Aproto.h nas-1.9/lib/audio/Aproto.h
--- nas-1.9.org/lib/audio/Aproto.h 2006-08-13 20:33:08.000000000 +0200
+++ nas-1.9/lib/audio/Aproto.h 2007-08-11 17:58:47.000000000 +0200
@@ -99,7 +99,7 @@
#define AU_DEFAULT_TCP_PORT 8000
#define AU_DEFAULT_DECNET_TASK "AUDIO$"
-#define AU_DEFAULT_UNIX_PATH "/tmp/.sockets/audio"
+#define AU_DEFAULT_UNIX_PATH "/var/run/nasd/audio"
#define auFalse 0
#define auTrue 1
diff -Naur nas-1.9.org/server/os/connection.c nas-1.9/server/os/connection.c
--- nas-1.9.org/server/os/connection.c 2007-03-18 07:55:09.000000000 +0100
+++ nas-1.9/server/os/connection.c 2007-08-11 19:05:02.000000000 +0200
@@ -203,10 +203,10 @@
#ifdef hpux
#define X_UNIX_DIR "/usr/spool/sockets/audio"
#define X_UNIX_PATH "/usr/spool/sockets/audio/"
-#define OLD_UNIX_DIR "/tmp/.sockets"
+#define OLD_UNIX_DIR "/var/run/nasd"
#else
-#define X_UNIX_DIR "/tmp/.sockets"
-#define X_UNIX_PATH "/tmp/.sockets/audio"
+#define X_UNIX_DIR "/var/run/nasd"
+#define X_UNIX_PATH "/var/run/nasd/audio"
#endif
#endif
This one I am not sure about either... It does sound like a good
idea, but:
- Is this the generally accepted practice for linux now? Should we
'#if defined(linux)' it?
- looking briefly, it looks like at least Solaris 10 also does the
/var/run thing... Are there any Solaris people that think this
should be done on that platform by default too?
- *BSD's? What are they doing these days?
I don't want to add this particular patch as-is (at least for 1.9.1)
since it will affect all OS's. I think it would be ok with an 'if
defined(linux)' though.
--
Jon Trulson mailto:jon@xxxxxxx
Xi Graphics, Inc. http://www.xig.com
#include <stddisclaimer.h>
"I am Nomad." -Nomad