Re: [nas] 2 possible patches for the 1.9.1 version

[Jon Trulson <jon@xxxxxxx>]

On Fri, 2 Nov 2007, Paul Fox wrote:

> =?utf-8?b?rnjhbmsgqso8dhruzxi=?= wrote:
> > nas-1.9/server/dda/voxware/auvoxware.c.leave-the-mixer-alone-it's-not-your-job
> > nas-1.9/server/dda/voxware/auvoxware.c
> > ---
> > nas-1.9/server/dda/voxware/auvoxware.c.leave-the-mixer-alone-it's-not-your-job
> > 2007-11-02 11:27:04.000000000 -0400
> > +++ nas-1.9/server/dda/voxware/auvoxware.c	2007-11-02 11:27:56.000000000
> > -0400
> > @@ -467,8 +467,9 @@ mixerInputModeToNAS(int input_mode)
> >  static void
> >  setMixerDefaults(void)
> >  {
> > -    setPhysicalOutputGain(auDefaultOutputGain);
> > -    setPhysicalInputGainAndLineMode(auDefaultInputGain,
> > AuDeviceLineModeLow);
> > +    /* Do not mess with the mixer defaults. */
> > +    /* setPhysicalOutputGain(auDefaultOutputGain); */
> > +    /* setPhysicalInputGainAndLineMode(auDefaultInputGain,
> > AuDeviceLineModeLow); */
> >  }
> >
>
> that doesn't seem like a very friendly thing to do to
> a routine called "setMixerDefaults()".  :-)

  Agreed, not a good patch at all :)

> did you look at the code?  there's a config option for this, isn't there?
>
>    MixerInit "no"

   Yes, that is what the MixerInit option is supposed to do.

   I would be ok with making the default of MixerInit to be "no"
   rather than yes, as it is now for 1.9.1...


--
Jon Trulson    mailto:jon@xxxxxxx
Xi Graphics, Inc.  http://www.xig.com
#include <stddisclaimer.h>
"I am Nomad." -Nomad